Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IBX-1294: Fixed deprecated RequestStack::getMasterRequest usages #85

Merged
merged 2 commits into from
Oct 20, 2021
Merged

IBX-1294: Fixed deprecated RequestStack::getMasterRequest usages #85

merged 2 commits into from
Oct 20, 2021

Conversation

adamwojs
Copy link
Member

@adamwojs adamwojs commented Oct 19, 2021 •
edited
Loading

Question Answer
JIRA issue IBX-1294
Type improvement
Target version 3.3+
BC breaks no
Tests pass yes
Doc needed no

TODO:

  • Implement tests.
  • Fix new code according to Coding Standards ($ composer fix-cs).
  • Ask for Code Review.

@adamwojs adamwojs self-assigned this Oct 19, 2021
@adamwojs adamwojs changed the title IBX-1294: Fixed deprecated Symfony\Component\HttpFoundation\RequestStack::getMasterRequest usages IBX-1294: Fixed deprecated RequestStack::getMasterRequest usages Oct 19, 2021
@sonarcloud
Copy link

sonarcloud bot commented Oct 20, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@adamwojs adamwojs requested review from ViniTou, alongosz, Steveb-p and a team October 20, 2021 06:59
@Steveb-p Steveb-p requested a review from a team October 20, 2021 07:04
@ViniTou ViniTou merged commit 617a9f0 into 1.3 Oct 20, 2021
@ViniTou ViniTou deleted the ibx_1294 branch October 20, 2021 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Steveb-p Steveb-p Steveb-p approved these changes

@ViniTou ViniTou ViniTou approved these changes

@alongosz alongosz Awaiting requested review from alongosz

Assignees

@adamwojs adamwojs

@Steveb-p Steveb-p

@alongosz alongosz

@ViniTou ViniTou

Labels
None yet
Milestone
No milestone
4 participants
@adamwojs @Steveb-p @ViniTou @alongosz